Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installed and added standardJS static tool #57

Open
wants to merge 2 commits into
base: f24
Choose a base branch
from

Conversation

J0nathanLai
Copy link

@J0nathanLai J0nathanLai commented Oct 23, 2024

Static Tool From List: StandardJS

Files Added:
standardjs-install-log.txt
standardjs-check-log.txt

Description:

  1. Ran npm install standard --save-dev in my local repository to install the StandardJS static analysis tool. Inside the file standardjs-install-log.txt, you can see the output log generated from installing the static analysis tool
Screenshot 2024-10-23 at 1 27 31 AM

We can also see that on line 173 of the package.json file (which is inside .gitignore file), the standardJS was added to the package.json file.
Screenshot 2024-10-23 at 10 39 50 PM

  1. ran npx standard . to use the StandardJS static analysis tool. Inside the file standardjs-check-log.txt, you can see the output log generated from using the tool and the checks it performed on the nodebb code. Below is a snippet of the log that shows different ways to reformat the nodebb code to satisfy StandardJS' formatting.
Screenshot 2024-10-23 at 1 27 37 AM

@coveralls
Copy link

coveralls commented Oct 23, 2024

Pull Request Test Coverage Report for Build 11599946861

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.676%

Totals Coverage Status
Change from base Build 11494762754: 0.0%
Covered Lines: 22331
Relevant Lines: 25591

💛 - Coveralls

@J0nathanLai J0nathanLai self-assigned this Oct 24, 2024
Copy link

@anna-mat anna-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! You have written a detailed pull request and included necessary logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants