forked from CMU-313/cmu-313-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool Installation: Prettier #20
Open
emshyu
wants to merge
15
commits into
f24
Choose a base branch
from
emily-prettier-install
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11511413906Details
💛 - Coveralls |
KEY DETAILS FOR COMPLETE INTEGRATION:
|
Because Prettier conflicts with Eslint, despite interventions, this branch will not be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prettier is a static analysis tool that checks for consistent code style and has code reformatting capabilities. The tool will need further testing of rules so that it can coexist with EsLint. Currently, both tools can be run separately. Attached below is the command line stdout and stderr output of a successful run of 'npx prettier . --check' on our current nodebb codebase, a command that checks the style of the code.
Proof of installation:
Proof of running the tool successfully:
prettierinstallationproof.txt
KEY DETAILS FOR COMPLETE INTEGRATION: