Adding a question resolved feature to the current NodeBB frame. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial trial on updating skin based on time in day
Pivoted to problem-solved feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status of the question is showed next the the question (resolved / unresolved). At the start of the question, there is a toggle button that can switch the question between "resolved" and "unresolved".
There is issue with the backend structure for storing data and accurately retrieve the status.
Run ./nodebb build tpl
Navigate to any question post.
If a new topic is created it is default to "unresolved"
After topic is posted, user can toggle between resolved and unresolved.
Automated Test:
Due to the front-end and back-end margin error, the feature I was working on could not be fully implemented. Automated tests are most effective when the feature is complete, as they validate functionality across various scenarios. Since the feature is not yet in a working state, any test I write at this point would fail, not because of issues with the logic or implementation, but because of the unresolved margin error. Writing tests now would not accurately reflect the functionality of the feature and could lead to misleading results. Therefore, I believe it’s more efficient to focus on resolving the margin error first, and once the feature is functioning as expected, I will write the automated tests to ensure the feature is properly validated.
Issues Addressed:
#27
#28
#29