Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issues #21,#22,#23] Role Display Feature #24

Open
wants to merge 7 commits into
base: f24
Choose a base branch
from

Conversation

evelynzhengg
Copy link

@evelynzhengg evelynzhengg commented Oct 10, 2024

User's role appears next to their username when they post a topic and when they post a reply (refresh is required to view tag on replies)

  • Issue with updating schema to appropriately have role, leading to test failure.

How to test role displays:

  • Run ./nodebb build tpl
  • Navigate to “General Discussion”
  • Create a new topic to see your role next to your username
  • Go into the topic and make a reply
  • Refresh the page to view your role next to the comment

Automated testing for role display:

  • Test added to test/topics/events.js to ensure correct role assignment to each topic.
  • Run test with npm run test

Issues Addressed:
#21
#22
#23

Role shows up next to topic (rendered in categories.tpl):
image

Role shows up next to the replies:
image

@evelynzhengg evelynzhengg added this to the Sprint 2 milestone Oct 10, 2024
Copy link

@Nita242004 Nita242004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standardize spacing, and make sure to fix linter tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants