Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #142: Updated jquery and jquery.ui js files #300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

QiyouChang
Copy link

These are newer version of these modules to fix issue #142.
The issue is that the front-end javascript modules currently used by Teedy is very outdated and has security vulnerabilities. Before my correction, there are 12 vulnerable modules which include jquery, jquery ui, angular js, and underscore and the metric score is 92.
Best Practices Section Before
To solve this issue, I replaced jquery and jquery ui with newer version which turns 12 vulnerabilities to 6.
Best Practices Section After
The metric can not be improve and is still at 92 after all my attempts (communicated with professors and Professor Hilton approves it):
Screen Shot 2022-09-08 at 17 24 31
Here are all my attempts and reasons why 92 is the best score for this section:

Comparing angular js version 1.6.6 on the left with the newest version 1.8.2 on the right in the screenshot, I can only find two (sanitize, touch) files out of 1.6.6 that exist in 1.8.2. I tried to switch only these two files with new versions which failed. Then, I compared the respective angular.js (main file). I noticed a lot of changes and new variables which caused another failure when I switched only the angular.js file. Failure in running Teedy also occurred when I tried to switch underscore.js. As underscore.js is called in angular files, changing underscore.js only actually causes a blank page response.

I came to a conclusion that Angular js and underscore.js are dependent modules with big variables/functions changes between old and newer versions. I looked up how the Teedy's code maintenance people upgrade their JS libraries and I noticed that it takes them about 63 changed files with 75,210 additions and 18,774 deletions in order to accomplish this task (issue151 of the original Teedy(not cmu one), screenshot attached). From this point, I know it would be impossible for me to continue on this issue.
issue 151

Thanks.
George Chang

These are newer version of these modules to fix issue CMU-313#142.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant