Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing #586

Open
wants to merge 7 commits into
base: f24
Choose a base branch
from
Open

testing #586

wants to merge 7 commits into from

Conversation

swaeliu
Copy link

@swaeliu swaeliu commented Sep 6, 2024

test commit-- version one.

@coveralls
Copy link

coveralls commented Sep 6, 2024

Pull Request Test Coverage Report for Build 11025669036

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 82.666%

Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10607818019: -0.005%
Covered Lines: 22322
Relevant Lines: 25582

💛 - Coveralls

@swaeliu
Copy link
Author

swaeliu commented Sep 6, 2024

Hi, I am not sure why I have a failing case for duplicate code--the duplicate happens to be exactly the bit that I did not change at all and just copied from the original on SonarCloud. Could it be that someone was working on this issue already?

@swaeliu
Copy link
Author

swaeliu commented Sep 6, 2024

Refactored code in lines 9 through 24. Specifically moved the some parts of the control flow around to prevent deeply nested functions. Also, sonar cloud states that quality gate is failed because of code duplication error... This is acceptable because my file handles mouse click events and toggling--parts of this code are found across the codebase.

Thus, the duplication error is justified because very similar functions exist throughout the codebase to perform mouse toggling.

Copy link

sonarcloud bot commented Sep 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
40.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants