-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring a function from src/controllers/accounts/helpers.js to reduce its cognitive complexity from 30 to 15 #553
Open
MaryamAlkhater
wants to merge
15
commits into
CMU-313:f24
Choose a base branch
from
MaryamAlkhater:feature
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 3, 2024
-
splitting function into helper function
Maryam Alkhater authored and Maryam Alkhater committedSep 3, 2024 Configuration menu - View commit details
-
Copy full SHA for bcadb80 - Browse repository at this point
Copy the full SHA bcadb80View commit details -
fixing helper functions errors
Maryam Alkhater authored and Maryam Alkhater committedSep 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 4564f15 - Browse repository at this point
Copy the full SHA 4564f15View commit details -
Maryam Alkhater authored and Maryam Alkhater committed
Sep 3, 2024 Configuration menu - View commit details
-
Copy full SHA for ffff934 - Browse repository at this point
Copy the full SHA ffff934View commit details -
Maryam Alkhater authored and Maryam Alkhater committed
Sep 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 9ae1edb - Browse repository at this point
Copy the full SHA 9ae1edbView commit details -
Maryam Alkhater authored and Maryam Alkhater committed
Sep 3, 2024 Configuration menu - View commit details
-
Copy full SHA for fd63044 - Browse repository at this point
Copy the full SHA fd63044View commit details -
Maryam Alkhater authored and Maryam Alkhater committed
Sep 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 226ac81 - Browse repository at this point
Copy the full SHA 226ac81View commit details -
Maryam Alkhater authored and Maryam Alkhater committed
Sep 3, 2024 Configuration menu - View commit details
-
Copy full SHA for 75b8bab - Browse repository at this point
Copy the full SHA 75b8babView commit details
Commits on Sep 4, 2024
-
Maryam Alkhater authored and Maryam Alkhater committed
Sep 4, 2024 Configuration menu - View commit details
-
Copy full SHA for b45aa76 - Browse repository at this point
Copy the full SHA b45aa76View commit details -
Maryam Alkhater authored and Maryam Alkhater committed
Sep 4, 2024 Configuration menu - View commit details
-
Copy full SHA for c9f2b2c - Browse repository at this point
Copy the full SHA c9f2b2cView commit details -
Maryam Alkhater authored and Maryam Alkhater committed
Sep 4, 2024 Configuration menu - View commit details
-
Copy full SHA for e66b5ac - Browse repository at this point
Copy the full SHA e66b5acView commit details
Commits on Sep 5, 2024
-
Maryam Alkhater committed
Sep 5, 2024 Configuration menu - View commit details
-
Copy full SHA for b42dbf6 - Browse repository at this point
Copy the full SHA b42dbf6View commit details -
Maryam Alkhater authored and Maryam Alkhater committed
Sep 5, 2024 Configuration menu - View commit details
-
Copy full SHA for 557c2df - Browse repository at this point
Copy the full SHA 557c2dfView commit details -
Maryam Alkhater authored and Maryam Alkhater committed
Sep 5, 2024 Configuration menu - View commit details
-
Copy full SHA for c67c6bd - Browse repository at this point
Copy the full SHA c67c6bdView commit details
Commits on Sep 6, 2024
-
Maryam Alkhater authored and Maryam Alkhater committed
Sep 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 5370a58 - Browse repository at this point
Copy the full SHA 5370a58View commit details -
Merge branch 'f24' into feature
Maryam Alkhater authored and Maryam Alkhater committedSep 6, 2024 Configuration menu - View commit details
-
Copy full SHA for 59b2e27 - Browse repository at this point
Copy the full SHA 59b2e27View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.