-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring code in public/src/admin/dashboard.js #500
base: f24
Are you sure you want to change the base?
Conversation
Refactoring code in public/src/admin/dashboard.js CMU-313#418
Pull Request Test Coverage Report for Build 10731404739Details
💛 - Coveralls |
Quality Gate passedIssues Measures |
Resolves #418 Link to issue: https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=CMU-313_NodeBB&open=AZFmi_6XybYwxy-_uEU- Refactored code in public/src/admin/dashboard.js to not have functions nested more than 4 levels deep. I created a helper function, "updateTranslator" to be called after "updateGraphTraffic" is called on line 353. This is instead of the function that was originally made on line 348. Inside my helper function, I inserted a console.log with my name to ensure that my name would show up on my console. I started my server, and went on the local host. I logged into admin, then on the dashboard page, I clicked on any of the "Last 30 days" "Last 7 days" or "Last 24 hours" in order to trigger my console log and see my name on my console. |
Resolved #418