-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing #586
base: f24
Are you sure you want to change the base?
testing #586
Conversation
Pull Request Test Coverage Report for Build 11025669036Details
💛 - Coveralls |
Hi, I am not sure why I have a failing case for duplicate code--the duplicate happens to be exactly the bit that I did not change at all and just copied from the original on SonarCloud. Could it be that someone was working on this issue already? |
Refactored code in lines 9 through 24. Specifically moved the some parts of the control flow around to prevent deeply nested functions. Also, sonar cloud states that quality gate is failed because of code duplication error... This is acceptable because my file handles mouse click events and toggling--parts of this code are found across the codebase. Thus, the duplication error is justified because very similar functions exist throughout the codebase to perform mouse toggling. |
Quality Gate failedFailed conditions |
test commit-- version one.