Resolved Issue No. 9 - Accessibility improvements to "create a tag" page. Score increased from 85 to 98. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neric forms and changed aria-ID in menu_main for top left row
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolve Issue No. 9: (#9).
The main two issues I tackled had to do with the create a tags page overall accessibility. First, I changed the button colors to a darker color to improve color contrast. Second, I changed the text colors as well to a darker color to improve contrast. Lastly, I changed the ARIA ids in some headers so that they are all unique. All together the accessibility score jumped from 85 to 98 with my changes.
this commit fixes #9