resolved ARIA IDs issue #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. 'headingToggle,' 'headingSet,' 'headingToggled.'
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the lighthouse report, there were multiple ARIA IDs (specifically from the left side options and dropdown lists) that were named "headingOne," which lowered the score of the site. The report stated that this could compromise the experience of users utilizing assistive technologies.
I've looked through the HTML files the issue stemmed from and changed the ids to be "headingToggle" for buttons that lead to a dropdown list, "headingToggled" for buttons in the dropdown lists, and "headingSet" for buttons that have one direct function.
This change improved the lighthouse Accessibility score from 89 to 96 and the Performance score from 61 to 76.