BFD-3126: Pipeline manages its own scale-in #2518
Conversation
aschey-forpeople
requested review from
mjburling,
dondevun and
malessi
as code owners
| @@ -0,0 +1,12 @@ | |||
| [tool.poetry] | |||
There was a problem hiding this comment.
I decided to go rogue and use poetry here. Overall I think it's much easier to manage than messing with pip-compile.
| @@ -52,5 +52,5 @@ Please indicate if this PR does any of the following: | |||
|
|
|||
| ### Validation | |||
|
|
|||
| Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable. | |||
| **Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.** | |||
There was a problem hiding this comment.
Decided to bold this bit so it's easier to differentiate the question from the response
| * The date when the final manifest list was implemented. Pipeline runs before this date won't | ||
| * have a manifest list. | ||
| */ | ||
| private static final Instant FINAL_MANIFEST_CUTOFF = Instant.parse("2024-12-12T00:00:00Z"); |
There was a problem hiding this comment.
This has a magic number feel, to me. Not sure how else to implement, though.
There was a problem hiding this comment.
We can remove it if/when we get rid of the old manifest loads, but it's necessary for now because manifest loads older than that don't have a manifest list file.
There was a problem hiding this comment.
There's similar logic elsewhere to handle older records before some feature was implemented.
aschey-forpeople
force-pushed
the
BFD-3126
branch
from
8726916 to
1451e85
Compare
aschey-forpeople
dismissed stale reviews from MahiFentaye and dondevun
via
96392d3
apps/utils/scripts/run-bfd-server
Outdated
| echo put-parameter $full_ssm_name | ||
| # some values may need to be escaped to be used as an env var | ||
| # but should be unescaped in SSM | ||
| value=$(echo "${value}" | tr -d '\') |
There was a problem hiding this comment.
Unrelated, had to make this change so that variables with quotes can be used in both SSM and environment variables due to unfortunate differences in escaping
JIRA Ticket:
BFD-3126
What Does This PR Do?
ManifestList.donefileNote that the manifest list file will not be moved to the "done" folder since we're removing the move logic soon anyway.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
Unit/integration tests, manually tested both synthetic and non-synthetic loads in an ephemeral environment.