BCDA-8528-Update-MaxIdleConnsPerHost #1019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8528
🛠 Changes
Improve worker performance by cleaning up idle connections
bluebutton.go
->NewBlueButtonClient
, in the transport, setMaxIdleConnsPerHost
ℹ️ Context
The default setting of 2 for
MaxIdleConnsPerHost
leads to a lot of sockets left in our kernel in theTIME_WAIT
state. Setting it to matchMaxIdleConns
mean that we get a lot more reuse per socket.References: Medium and GitHub