-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NOREF] Use new graphql-codegen tool #655
Conversation
"comments": { | ||
"on_resolutions": { | ||
"graphql": "Having graphql fixed at 15.8.0 allows apollo codegen and graphql-codegen to work together. Once the former is deprecated, you can remove this", | ||
"typed_document_node": "https://github.com/dotansimha/graphql-code-generator/issues/9293" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying something here - I wanted to document a few things that I did in the package.json, but since it's just JSON, it doesn't support actual comments, and some places online recommended just throwing a custom object in there for stuff like this!
Thanks for this, can't wait to use it! I like the idea of one file for all the generated types. Also not sure if I also love the name Are This works great! Looking through the documentation further to see if there could be any other useful additional config |
I'll go through these item by item!
Of course! 🙏
Same - I think it makes our file structure a bit cleaner, and navigating these auto-generated files is not usually of much importance
Same - I think I'll try committing a change to this in this spirit.
Everything in
👍 Appreciate it! Let me know if you identify anything 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, and the structure makes sense
EASI-000
Changes and Description
queriesCodegen
folder, where all queries will reside for the new codegen toolThe high level approach used here is to introduce
graphql-codegen
, which is more supported than the apollo codegen tool we're using (see this issue). The goal is to introduce a way to slowly cut over queries to this new codegen tool without having to completely and immediately deprecate apollo codegen.Looking for feedback on the following:
queriesCodegen
- could be convinced to name this something elseHow to test this change
scripts/dev gql
to ensure no files changesrc/queriesCodegen
and using it within the app!PR Author Review Checklist
PR Reviewer Guidelines