Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-2838] Help article: 2-pager meeting #653

Merged
merged 25 commits into from
Jul 31, 2023
Merged

[EASI-2838] Help article: 2-pager meeting #653

merged 25 commits into from
Jul 31, 2023

Conversation

garyjzhao
Copy link
Contributor

@garyjzhao garyjzhao commented Jul 27, 2023

EASI-2838

Changes and Description

  • Adjusted the RelatedArticles component
    • classname in the padding
    • Incorporate the View all help articles
  • twoPageMeeting.ts translations
  • src/views/HelpAndKnowledge/Articles/TwoPagerMeeting/index.tsx compoent

How to test this change

  1. Navigate to http://localhost:3005/help-and-knowledge
  2. See that new How to have a successful 2-pager meeting card is showing under the Getting started cards
  3. Click through and ensure article matches the figma
  4. Click through the Recommendations links to scroll around the article.

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@garyjzhao garyjzhao requested a review from a team as a code owner July 27, 2023 19:06
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for a team July 27, 2023 19:06
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I enter the article, the page starts halfway down

Screenshot 2023-07-31 at 12 38 13 PM

The margin-top here is a bit larger than in the Figma - between the description and links
Screenshot 2023-07-31 at 12 40 19 PM

@patrickseguraoddball
Copy link
Contributor

When I enter the article, the page starts halfway down

This is due to the multiple <PageHeading /> components. Truss has scroll built in, and there should only be one per page. Posting this for posterity, as Gary and I synced on this

Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just one tiny thing I saw. The y padding on the italics is tighter than in Figma

Screenshot 2023-07-31 at 1 07 11 PM

@patrickseguraoddball patrickseguraoddball self-requested a review July 31, 2023 17:29
Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG Thanks!

@garyjzhao garyjzhao merged commit 4dedc19 into main Jul 31, 2023
@garyjzhao garyjzhao deleted the EASI-2838/2pager branch July 31, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants