Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-2990] Disable forms until all data loaded #649

Merged
merged 36 commits into from
Jul 31, 2023

Conversation

garyjzhao
Copy link
Contributor

@garyjzhao garyjzhao commented Jul 20, 2023

EASI-2990

Changes and Description

  • Add a ` Wrapper around MINT forms to disable all functionality until data is loaded
  • Collaborators table loading render
  • When submitting the forms, make sure the button is disabled as well as the entire form

How to test this change

  1. work through the app with a throttled internet speed.
  2. Ensure the AC is met

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Updated the Postman Collection if necessary.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

@garyjzhao garyjzhao requested a review from a team as a code owner July 20, 2023 16:26
@garyjzhao garyjzhao requested review from patrickseguraoddball and removed request for a team July 20, 2023 16:26
@patrickseguraoddball
Copy link
Contributor

Just leaving the comment here that Gary and I synced, and waiting for cypress tests to be adjusted before giving final review

Copy link
Contributor

@patrickseguraoddball patrickseguraoddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet nice work!

@garyjzhao garyjzhao merged commit aa8875d into main Jul 31, 2023
@garyjzhao garyjzhao deleted the EASI-2990/disable-forms-until-all-data-loaded branch July 31, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants