Fix it gov request table sort by submission date #2960
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoddball
previously approved these changes
Jan 23, 2025
|
looks good! so we want newest last (and potentially not on first page)? |
EKS Ingress URLs |
|
@samoddball Thanks for catching that. Looks like it should be the other way around. |
|
@samoddball Thanks again. Should be good now. |
adamodd
commented
Jan 23, 2025
| a: Row<MergedRequestsForTable>, | ||
| b: Row<MergedRequestsForTable> | ||
| ) => { | ||
| return (a.original.submissionDate || 'z') > |
There was a problem hiding this comment.
Dates are an ISO string so comparing against a 'z' will put undefineds at the end.
There was a problem hiding this comment.
interesting! cool solution 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOREF
Description
Defines sorting for the ITGOV requests table
See https://oddball.slack.com/archives/C06RSLZ4UKF/p1734620705537649
Default sort on Submission Date descending with undefineds listed first
Now:
