Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASI-4463] Add TLC Phase to System Profile #2866

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

downeyn-cms
Copy link
Contributor

@downeyn-cms downeyn-cms commented Oct 23, 2024

EASI-4463 EASI-4426

Description

  • Added TLC Phase to System Profile header
  • I also bundled in a small text change (EASi-4426)
  • Updated snapshots accordingly

How to test this change

  • Ensure that TLC Phase is present in the header for all System Profiles and that it matches the value in System Workspace
  • Ensure that design and language matches Figma mockups

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@downeyn-cms downeyn-cms requested a review from a team as a code owner October 23, 2024 20:22
@downeyn-cms downeyn-cms requested review from aterstriep and removed request for a team October 23, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant