-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EASI-4649 Upgrade vite & vitest #2858
Conversation
This is in a good spot for meeting requirements, but just taking a little more time to see if other related upgrades should fit in. |
@adamodd would you mind (I know it's a bit of an odd request) pushing up a purposefully failing client test? I think that's the only time the new Once the tests run, we can probably just revert the commit! |
Force break is in but still don't see any UI hook to the error. How much would we actually use this since broken client tests should be blocked by our pre commit hook? |
This reverts commit 2c964f0.
Reverted reporting attempts because they failed |
Clear out leftover require()s
This reverts commit 44e258b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and all seem to work as expected!
EASI-4649
Description
vite
andvitest
to currentNote
There was an attempt to change package.json
type
tomodule
, but this was reverted and on hold because some dependencies and confs still rely on commonjs.How to test this change
Reinstall npm packages and expect business as usual.
PR Author Checklist
PR Reviewer Guidelines