Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EASI-4649 Upgrade vite & vitest #2858

Merged
merged 20 commits into from
Oct 22, 2024
Merged

EASI-4649 Upgrade vite & vitest #2858

merged 20 commits into from
Oct 22, 2024

Conversation

adamodd
Copy link
Contributor

@adamodd adamodd commented Oct 18, 2024

EASI-4649

Description

  • Bumps up vite and vitest to current
  • Adds github actions reporter to client test

Note

There was an attempt to change package.json type to module, but this was reverted and on hold because some dependencies and confs still rely on commonjs.

How to test this change

Reinstall npm packages and expect business as usual.

yarn install
yarn test
yarn start
yarn cypress:run

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@adamodd adamodd requested a review from a team as a code owner October 18, 2024 00:11
@adamodd adamodd requested review from aterstriep and removed request for a team October 18, 2024 00:11
samoddball
samoddball previously approved these changes Oct 18, 2024
samoddball
samoddball previously approved these changes Oct 18, 2024
@adamodd adamodd requested a review from a team as a code owner October 18, 2024 00:57
@adamodd adamodd requested review from samoddball and removed request for a team October 18, 2024 00:57
@adamodd
Copy link
Contributor Author

adamodd commented Oct 18, 2024

This is in a good spot for meeting requirements, but just taking a little more time to see if other related upgrades should fit in.

@ClayBenson94
Copy link
Collaborator

@adamodd would you mind (I know it's a bit of an odd request) pushing up a purposefully failing client test? I think that's the only time the new --reporter=github-actions will actually create anything for us to see 👀

Once the tests run, we can probably just revert the commit!

@adamodd
Copy link
Contributor Author

adamodd commented Oct 18, 2024

Force break is in but still don't see any UI hook to the error.
I'm guessing we need to set process.env.GITHUB_ACTIONS === 'true'
https://vitest.dev/guide/reporters#github-actions-reporter

How much would we actually use this since broken client tests should be blocked by our pre commit hook?

@adamodd
Copy link
Contributor Author

adamodd commented Oct 18, 2024

Reverted reporting attempts because they failed

Clear out leftover require()s
Copy link
Collaborator

@ClayBenson94 ClayBenson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and all seem to work as expected!

@adamodd adamodd merged commit f7ca40f into main Oct 22, 2024
12 checks passed
@adamodd adamodd deleted the EASI-4649/vite branch October 22, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants