-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EASI-3510/graph schema upgrade #2431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mynar7
reviewed
Feb 13, 2024
ClayBenson94
requested changes
Feb 14, 2024
ClayBenson94
previously approved these changes
Feb 14, 2024
ClayBenson94
previously approved these changes
Feb 14, 2024
ClayBenson94
approved these changes
Feb 14, 2024
samoddball
changed the title
EASI 3510/graph schema upgrade
EASI-3510/graph schema upgrade
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EASI-3510
Changes and Description
gqlgen
to v0.17.40map[string]interface{}
as the@goModel
, the scalars were coming through as strings instead of their declared scalar types, such asUUID
, for example. This was fixed ingqlgen
, but our resolvers were designed with this pattern (always having strings) in mind, so some functionality was updated in this PR to account for the types no longer being strings. Inputs below are where this is relevantinput TRBRequestChanges
input UpdateTRBRequestFormInput
input UpdateTRBAdviceLetterInput
input UpdateTRBAdviceLetterRecommendationInput
How to test this change
PR Author Review Checklist
PR Reviewer Guidelines