Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EASI-3510/graph schema upgrade #2431

Merged
merged 27 commits into from
Feb 14, 2024
Merged

Conversation

samoddball
Copy link
Contributor

@samoddball samoddball commented Feb 13, 2024

EASI-3510

Changes and Description

  • upgrade gqlgen to v0.17.40
  • changes that led to this not being a simple version bump: Map based input types fields are now coerced to the right type 99designs/gqlgen#2830
  • in places where we used map[string]interface{} as the @goModel, the scalars were coming through as strings instead of their declared scalar types, such as UUID, for example. This was fixed in gqlgen, but our resolvers were designed with this pattern (always having strings) in mind, so some functionality was updated in this PR to account for the types no longer being strings. Inputs below are where this is relevant
    • input TRBRequestChanges
    • input UpdateTRBRequestFormInput
    • input UpdateTRBAdviceLetterInput
    • input UpdateTRBAdviceLetterRecommendationInput

How to test this change

  • pull the branch, confirm all tests pass
  • run through any UI functionality that uses the above four inputs, such as:
    • creating and submitting a TRB Request (submission will not work if this change does not work)
    • updating an advice letter
    • updating an advice letter recommendation
    • adding subject areas to a TRB request as you are creating it

PR Author Review Checklist

  • Met the ticket's acceptance criteria, or will meet them in a subsequent PR.
  • Added or updated tests for backend resolvers or other functions as needed.
  • Added or updated client tests for new components, parent components, functions, or e2e tests as necessary.
  • Tested user-facing changes with voice-over and the rotor menu

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.
  • Always make comments, even if it's minor, or if you don't understand why something was done.

Sam Lawson and others added 19 commits January 23, 2024 15:55
@samoddball samoddball requested review from a team as code owners February 13, 2024 22:03
@samoddball samoddball requested review from mynar7 and removed request for a team February 13, 2024 22:03
@StevenWadeOddball StevenWadeOddball removed the request for review from a team February 13, 2024 22:18
go.mod Outdated Show resolved Hide resolved
pkg/graph/resolvers/trb_request_form.go Show resolved Hide resolved
pkg/graph/schema.graphql Outdated Show resolved Hide resolved
ClayBenson94
ClayBenson94 previously approved these changes Feb 14, 2024
ClayBenson94
ClayBenson94 previously approved these changes Feb 14, 2024
@samoddball samoddball merged commit bc6f4ba into main Feb 14, 2024
12 checks passed
@samoddball samoddball deleted the EASI-3510/graph_schema_upgrade branch February 14, 2024 17:56
@samoddball samoddball changed the title EASI 3510/graph schema upgrade EASI-3510/graph schema upgrade Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants