Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues related to group repeatable subsequent rows when there is a checkbox or radio input. #304

Closed
wants to merge 4 commits into from
Closed

Fix issues related to group repeatable subsequent rows when there is a checkbox or radio input. #304

wants to merge 4 commits into from

Commits on Apr 28, 2015

  1. Fix issues related to group repeatable subsequent rows when there is … 

    …a checkbox or radio input.

If the input is a checkbox or radio, the original value is needed or saving will not save the value (subsequent post saves work because inputs  will then have the required value set).
This patch conditionally adds values to radios and inputs on new repeatable and sets the checked attribute only on the default option (radios).
Fixes issue CMB2#257 (this will set reset text inputs as well), and CMB2#246 & CMB2#263(restores radio and checkbox values on new row saves)
    Miles Fink committed Apr 28, 2015
    Configuration menu
    Copy the full SHA
    d06cc9d View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2015

  1. Match formatting with exiting code

    Miles Fink committed Apr 29, 2015
    Configuration menu
    Copy the full SHA
    ed5ae33 View commit details
    Browse the repository at this point in the history

  2. Add another conditional for checkboxes and radios to preserve values … 

    …on cmb.emptyValue
    Miles Fink committed Apr 29, 2015
    Configuration menu
    Copy the full SHA
    8b5612b View commit details
    Browse the repository at this point in the history

Commits on May 15, 2015

  1. merge upstream original

    Miles Fink committed May 15, 2015
    Configuration menu
    Copy the full SHA
    fff4424 View commit details
    Browse the repository at this point in the history