-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metabox to edit-comment.php #238
Comments
Short answer is that it was just never added. I'd be happy to take a look at a PR if you're up for one. If it's not super clean, I may leave it as being better suited for an add-on. |
GregLancaster71
added a commit
to GregLancaster71/CMB2
that referenced
this issue
Mar 9, 2015
As Per: CMB2#238 *Changes in CMB2.php are optional for functionality.
Sorry about the multiple notifications guys, I had to change accounts on my local network and re-fork CMB2. |
pluginmirror-worker
pushed a commit
to wp-plugins/cmb2
that referenced
this issue
Jul 28, 2015
### Enhancements * Updated/Added many translations. Props [fxbenard](https://github.com/fxbenard), ([#203](CMB2/CMB2#344)) and [Mte90](https://github.com/Mte90) for the Italian translation. * Updated `'file_list'` field type to have a more intutive selection in the media library, and updated the 'Use file' text in the button. Props [SteveHoneyNZ](https://github.com/SteveHoneyNZ) ([#357](CMB2/CMB2#357), [#358](CMB2/CMB2#358)). * `'closed'` group field option parameter introduced in order to set the groups as collapsed by default. Requested in [#391](CMB2/CMB2#391). * Added `"cmb2_{$object_type}_process_fields_{$cmb_id}"` hook for hooking in and modifying the metabox or fields before the fields are processed/sanitized for saving. * Added Comment Metabox support. Props [GregLancaster71](https://github.com/GregLancaster71) ([#238](CMB2/CMB2#238), [#244](CMB2/CMB2#244)). * New "cmb2_{$field_id}_is_valid_img_ext" filter for determining if a field value has a valid image file-type extension. ### Bug Fixes * `'multicheck_inline'`, `'taxonomy_radio_inline'`, and `'taxonomy_multicheck_inline'` field types were not outputting anything since it's value was not being returned. Props [ediamin](https://github.com/ediamin), ([#367](CMB2/CMB2#367), ([#405](CMB2/CMB2#405)). * `'hidden'` type fields were not honoring the `'show_on_cb'` callback. Props [JPry](https://github.com/JPry), ([commits](CMB2/CMB2@5a4146e...1ef5ef1)). * Fixed: There was no minified cmb2-front.min.css file. * Fallback for fatal error with invalid timezone. Props [ryanduff](https://github.com/ryanduff) ([#385](CMB2/CMB2#385)). * Fix issues with deleting a row from repeatable group. Props [yuks](https://github.com/yuks) ([#387](CMB2/CMB2#387)). * Ensure value passed to `strtotime` in `make_valid_time_stamp` is cast to a string. Props [vajrasar](https://github.com/vajrasar) ([#389](CMB2/CMB2#389)). * Fixed issue with Windows IIS and bundling CMB2 in the theme. Props [DevinWalker](https://github.com/DevinWalker), ([#400](CMB2/CMB2#400), [#401](CMB2/CMB2#401)) git-svn-id: https://plugins.svn.wordpress.org/cmb2/trunk@1208582 b8457f37-d9ea-0310-8a92-e5e31aec5664
pluginmirror-worker
pushed a commit
to wp-plugins/cmb2
that referenced
this issue
Jul 28, 2015
### Enhancements * Updated/Added many translations. Props [fxbenard](https://github.com/fxbenard), ([#203](CMB2/CMB2#344)) and [Mte90](https://github.com/Mte90) for the Italian translation. * Updated `'file_list'` field type to have a more intutive selection in the media library, and updated the 'Use file' text in the button. Props [SteveHoneyNZ](https://github.com/SteveHoneyNZ) ([#357](CMB2/CMB2#357), [#358](CMB2/CMB2#358)). * `'closed'` group field option parameter introduced in order to set the groups as collapsed by default. Requested in [#391](CMB2/CMB2#391). * Added `"cmb2_{$object_type}_process_fields_{$cmb_id}"` hook for hooking in and modifying the metabox or fields before the fields are processed/sanitized for saving. * Added Comment Metabox support. Props [GregLancaster71](https://github.com/GregLancaster71) ([#238](CMB2/CMB2#238), [#244](CMB2/CMB2#244)). * New "cmb2_{$field_id}_is_valid_img_ext" filter for determining if a field value has a valid image file-type extension. ### Bug Fixes * `'multicheck_inline'`, `'taxonomy_radio_inline'`, and `'taxonomy_multicheck_inline'` field types were not outputting anything since it's value was not being returned. Props [ediamin](https://github.com/ediamin), ([#367](CMB2/CMB2#367), ([#405](CMB2/CMB2#405)). * `'hidden'` type fields were not honoring the `'show_on_cb'` callback. Props [JPry](https://github.com/JPry), ([commits](CMB2/CMB2@5a4146e...1ef5ef1)). * Fixed: There was no minified cmb2-front.min.css file. * Fallback for fatal error with invalid timezone. Props [ryanduff](https://github.com/ryanduff) ([#385](CMB2/CMB2#385)). * Fix issues with deleting a row from repeatable group. Props [yuks](https://github.com/yuks) ([#387](CMB2/CMB2#387)). * Ensure value passed to `strtotime` in `make_valid_time_stamp` is cast to a string. Props [vajrasar](https://github.com/vajrasar) ([#389](CMB2/CMB2#389)). * Fixed issue with Windows IIS and bundling CMB2 in the theme. Props [DevinWalker](https://github.com/DevinWalker), ([#400](CMB2/CMB2#400), [#401](CMB2/CMB2#401)) git-svn-id: https://plugins.svn.wordpress.org/cmb2/trunk@1208586 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looked through
https://github.com/WebDevStudios/CMB2-Snippet-Library
and didn't see a snippet for this. CMB2 says it supports aobject_type => array( 'comment', )
but I don't see the functionality built into the code. Is there a way to do this with filters?Adding the functionality would not be hard. A dozen lines in
CMB2_Hookup.php
infunction admin_hooks()
would do it. So I think its safe to assume this was an intentional exclusion?The text was updated successfully, but these errors were encountered: