Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable processing to the configuration pointer. #891

Merged
merged 6 commits into from
Jun 27, 2023

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Jun 23, 2023

Fixes #890

Add parsing of environmental variables when supplied for the config file option.

@phlptp phlptp added the bug label Jun 23, 2023
@phlptp phlptp force-pushed the config_environmental_variable branch from a454aa3 to f58f3dd Compare June 23, 2023 19:34
@phlptp phlptp force-pushed the config_environmental_variable branch from 5bde394 to 45905e6 Compare June 23, 2023 19:41
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (84cad16) 99.46% compared to head (c01e634) 99.46%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          18       18           
  Lines        4086     4096   +10     
=======================================
+ Hits         4064     4074   +10     
  Misses         22       22           
Impacted Files Coverage Δ
include/CLI/StringTools.hpp 100.00% <ø> (ø)
include/CLI/TypeTools.hpp 100.00% <100.00%> (ø)
include/CLI/impl/App_inl.hpp 99.31% <100.00%> (+<0.01%) ⬆️
include/CLI/impl/StringTools_inl.hpp 95.62% <100.00%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@phlptp phlptp merged commit a1135bb into main Jun 27, 2023
@phlptp phlptp deleted the config_environmental_variable branch June 27, 2023 18:40
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration files not working with envname
1 participant