Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a few more coverage tests #794

Merged
merged 10 commits into from
Oct 28, 2022
Merged

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Oct 27, 2022

try to add a few more coverage tests and fix some markdown issues

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 99.29% // Head: 99.42% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (c27bd03) compared to base (b681d4d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #794      +/-   ##
==========================================
+ Coverage   99.29%   99.42%   +0.12%     
==========================================
  Files          16       16              
  Lines        3974     3972       -2     
==========================================
+ Hits         3946     3949       +3     
+ Misses         28       23       -5     
Impacted Files Coverage Δ
include/CLI/ConfigFwd.hpp 100.00% <ø> (+1.88%) ⬆️
include/CLI/impl/Validators_inl.hpp 99.51% <ø> (+0.95%) ⬆️
include/CLI/TypeTools.hpp 100.00% <0.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@henryiii henryiii merged commit 4dbe4b4 into CLIUtils:main Oct 28, 2022
@henryiii henryiii deleted the coverage_testing branch October 28, 2022 04:23
@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Oct 28, 2022
@henryiii henryiii removed the needs README Needs to be mentioned in the README label Oct 28, 2022
@henryiii
Copy link
Collaborator

Thanks for working on this! #793 shows that we need it.

@henryiii henryiii removed the needs changelog Hasn't been added to the changelog yet label Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants