fix: static analysis problems #785
Conversation
* fix to warrnings reported by Klocwork in CLI11 v2.2.0
| @@ -750,7 +750,7 @@ class AsNumberWithUnit : public Validator { | |||
|
|
|||
| // transform function | |||
| func_ = [mapping, opts](std::string &input) -> std::string { | |||
| Number num; | |||
| Number num{}; | |||
There was a problem hiding this comment.
Not sure this is necessary, but it's okay.
There was a problem hiding this comment.
I understand that this is just a cosmetic change. I just wanted to hold the tool back from moaning.
There was a problem hiding this comment.
If it's just a cosmetic change, I'd have no problem with it. I think it might zero initialize some types, which is technically wasteful, the will only be written to. But in the scope of parsing CLI code, it's totally acceptable.
There was a problem hiding this comment.
I completely understand your point of view
Codecov ReportBase: 99.29% // Head: 99.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 16 16
Lines 3973 3974 +1
=======================================
+ Hits 3945 3946 +1
Misses 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Henry Schreiner <[email protected]>
Co-authored-by: Henry Schreiner <[email protected]>
github-actions
bot
added
needs changelog
fixes #784 - warnings reported by Klocwork in CLI11 v2.2.0