Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a transform/validator that checks for files on a default path. #698

Merged
merged 7 commits into from
Jan 31, 2022

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Jan 28, 2022

This is an alternative to #684 and closes #682. It add a transform/validator that checks for a file and on a default path.
This if used with a config ptr can be used to add a default path, or any number of default paths for that matter.

I think it has the same capabilities as #684 without adding any additional API calls and adding a new validator which may have other uses as well.

@phlptp phlptp requested a review from henryiii January 28, 2022 20:25
@phlptp
Copy link
Collaborator Author

phlptp commented Jan 28, 2022

This will need a couple more test cases and some docs before merging but wanted to see what @henryiii and Firefly35 thought of this alternative.

@henryiii
Copy link
Collaborator

This looks good, works within the existing infrastructure, and can be expanded to look in several locations (like ~/.config and ./.config, etc). I think a bit of docs showing how to use it would be useful.

README.md Outdated Show resolved Hide resolved
book/chapters/config.md Outdated Show resolved Hide resolved
@phlptp phlptp merged commit 2565594 into CLIUtils:main Jan 31, 2022
@phlptp phlptp deleted the FileOnDefaultPathTransform branch January 31, 2022 23:07
@github-actions github-actions bot added the needs changelog Hasn't been added to the changelog yet label Jan 31, 2022
@sg-james
Copy link

sg-james commented Feb 9, 2022

Apologies for bumping, but I believe this PR might have accidentally closed issue #694 by accident and meant to close issue #682.

@henryiii
Copy link
Collaborator

henryiii commented Feb 9, 2022

Corrected, thanks!

@henryiii henryiii removed the needs changelog Hasn't been added to the changelog yet label Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set a config root folder with set_config
3 participants