Fix the compile issues with the boost<optional> tests and catch #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have any of the CI tests using boost? |
|
I think we did, but GitHub Actions/Azure dropped Boost from the default image, so we might not anymore. |
|
I tested this on my local machine, but not sure how we can go about getting a CI test with boost to catch stuff like this and run the other boost related tests |
henryiii
force-pushed
the
boost_optional_catch_fix
branch
2 times, most recently
from
5796dbd
to
f99890b
Compare
henryiii
force-pushed
the
boost_optional_catch_fix
branch
from
f99890b
to
47fe729
Compare
github-actions
bot
added
needs changelog
henryiii
removed
needs changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #645