-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group merge #1039
Group merge #1039
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 17 17
Lines 4546 4569 +23
Branches 0 976 +976
==========================================
+ Hits 4546 4569 +23 ☔ View full report in Codecov by Sentry. |
@henryiii unless I hear some objections I am going to merge this on Monday. |
Sounds good. Let me know if there’s anything specific to review. At PyCon currently. |
Mostly if you have any concerns about the notation itself and having slightly different behavior depending on the option group name. I know there have been several requests for this capability and I am a little reticent to add more modifiers and options, so this seemed like a nice solution. |
That wouldn't be covered by this? |
It should be. The way the mechanic works is that the option would get associated with a parent group, that could be the main app or a sub_group. So you could tie any number of sub_groups together for help display as part of the main app or in another sub group. |
This PR adds a mechanism to hide groups but have their options visible as part of the parent.
This works for option group names starting with a '+'
for example
will produce help as
instead of
Fixes issue #1034 and a few other past issues or questions