fix#17 : create base for players #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amustache
requested changes
Nov 28, 2022
| @@ -0,0 +1,28 @@ | |||
| # SECURITY WARNING: keep the secret key used in production secret! | |||
There was a problem hiding this comment.
comment je fais pour pas push un truc en particulier ?
Comment on lines
+23
to
+27
|
|
||
|
|
||
| # sur-roles de player : PAS MTN | ||
| #class Manager(Player): | ||
| # activity = models.ForeignKey("activity.Activity", on_delete=models.CASCADE) |
| path("player/new", PlayerCreateView.as_view(), name="player_new"), | ||
| path("player/<pk>/show", player_show, name="player_show"), | ||
| #path("player/<pk>/select", player_select, name="player_select"), --> we don't select players lol |
|
|
||
|
|
||
| from .models import Player | ||
|
|
||
|
|
||
| class PlayerCreateView(CreateView): | ||
| model = Player | ||
| fields = ["name", "discord", "name"] | ||
| fields = ["name", "event", "discord", "Telegram"] #comment faire pr qu'il affiche une liste d'events quand je veux créer / edit un player |
There was a problem hiding this comment.
Faut pas mettre de commentaires qui sont des questions ou qui ne sont pas utiles pour la personne qui code/review.
Si tu le souhaites tu peux le mettre directement en question dans l'issue ou dans la MR
|
Ah oui et la convention pour un titre de MR c'est "Fix #<numero>: <titre>", ici par exemple "Fix #17: Create base for Players" (; |
Marwa-rez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
petit début, il manque encore de fix l'interface de base (issue#44) pour pouvoir accéder aux menus : new player et players (list). Sinon on peut tester en tapant directement les URLs