Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nt_zbgc_frac #300

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Fix nt_zbgc_frac #300

merged 1 commit into from
Feb 19, 2020

Conversation

dabail10
Copy link
Contributor

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Make sure nt_zbgc_frac is initialized when z_tracers is .false.
  • Developer(s):
    David Bailey (dabail10)
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Ran base_suite.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
      Just changes the printed value for nt_zbgc_frac when z_tracers is .false.
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

@dabail10 dabail10 requested a review from apcraig February 18, 2020 21:11
eclare108213
eclare108213 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you're just moving the initialization out of a conditional block so that it's always initialized. Good, thanks.

@apcraig apcraig merged commit 877c679 into CICE-Consortium:master Feb 19, 2020
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
@apcraig
Refactor bit-for-bit diagnostics (CICE-Consortium#300)
d417b97 
* implement bfb for mpi comm global sums, fix compile issue with cpps, remove unused cpps

* add set_nml.reprosum

* update global reductions for serial mode to leverage bfbflag in the same way as mpi mode

* update and fix bfb compare feature

* add comparelog.csh script and logbfb test

* update travis gcc, fix tdir feature with tests

* update Makefile for c compiles, update Macros files to support c compile and serial/parallel compiles better and cleaner

* modify report results script to address grep for bfbcomp cases, add first_suite.ts

* fix Macros.onyx_intel, accidently removed debug flags in earlier commit

* update travis c build

* fix script logic for more threads than tasks per node

* update scripts to address CICE-Consortium#299, poll_queue script and CICE-Consortium#301, single test bgen default use

* add QSTAT variables to fram and cesium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apcraig apcraig apcraig approved these changes

@eclare108213 eclare108213 eclare108213 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dabail10 @eclare108213 @apcraig