-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send broadband fswthrun by categories to coupler. #495
Conversation
Are changes needed in the cap as well? How will send_i2x_per_cat be set? send_i2x_per_cat is a very CESM-centric name. Would something like "save_fswthrunByCat" or similar be better? |
The cap will receive a flag from the coupler/mediator calling for the fluxes by category. I will update the NUOPC cap in a separate PR. The CICE standalone cap does not need to be updated. I am happy to rename the logical flag. |
@dabail10, sounds good. I'd wait for some other reviews before deciding on the name of the flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with send_i2x_per_cat. It's understandable (at least for those of us with some CESM experience) and it's general so that if other variables need to be sent, the same flag can be used.
Where is it declared? Should ice_init.F90 be here too?
send_i2x_per_cat is declared in ice_flux.F90 and set to .false. by default. It is not meant to be read in via the namelist. |
@eclare108213, @dabail10 is this ready to approve/merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eclare108213, it's hardwired for now. The changes in the NUOPC cap still need to be implemented to turn this feature on. |
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
This just introduces two new variables, send_i2x_per_cat and fswthrun_ai for sending to the coupler or not.
dabail10 (D. Bailey)
https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_mach_forks#cheyenne
This is an internal flag that is activated by the cap/driver and not a namelist variable. If the coupler requires this then it will turn it on. Another update is coming from the NUOPC cap that uses this. This is related to issue Send fswthru by categories to coupler #482.