-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robustify GitHub Actions workflow #588
Labels
Comments
[Aside: maybe a new label "CI" or "Continuous Integration" could be added for these types of issues.] |
apcraig
added a commit
to apcraig/CICE
that referenced
this issue
Apr 1, 2021
Update CI wget implementation CICE-Consortium#588 Create variable in ice_forcing.F90 called mixed_layer_depth_default and use it instead of c20 Fix bug in hourly output, created in time manager update CICE-Consortium#589 Set start year for all runs to 2005 and turn leap years on by default Update documentation in history output section to add information about hist_avg namelist, noted in CICE-Consortium#566
16 tasks
apcraig
added a commit
that referenced
this issue
Apr 6, 2021
…efault value (#586) * Update gx1 ic - update set_nml.gx1prod to match current production system - add apr 1 test case for gx1 - update landice tests, use gx1 - fix hmix default #585 - delete old code in ice_forcing.F90 (should have been done in earlier PR) * update gx1coreii initial condition * update icepack * add gx1 debug test, expected to fail * Update version number to 6.2.0 * Update gx3 and gx1 input filenames Update CI wget implementation #588 Create variable in ice_forcing.F90 called mixed_layer_depth_default and use it instead of c20 Fix bug in hourly output, created in time manager update #589 Set start year for all runs to 2005 and turn leap years on by default Update documentation in history output section to add information about hist_avg namelist, noted in #566 * update ic filenames, tests, and documentation * update color links in test results wiki * update hmix initialization
Thanks @apcraig! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes the GitHub Actions CI runner encounters a broken connection to Zenodo:
https://github.com/CICE-Consortium/CICE/pull/587/checks?check_run_id=2230759756#step:11:58435
The 'Download input data' step is successful in the workflow, despite wget encoutering an error. It's not the first time this happens, and I think I understand why. Each step in the workflow is ran by the shell specified by the "shell" keyword, or a platform default:
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell
We use the Cshell ("csh") (which in theory is not necessary, see #557) and thus use a custom shell:
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#custom-shell
CICE/.github/workflows/test-cice.yml
Lines 18 to 20 in e204fb8
but this invocation of csh does not ensure that any error encountered terminates the process, which is what is done by default for ex. Bash (see the Github documentation). So we should at least be using
/bin/csh -e {0}
to ensure errors are caught.Also, we should invoke 'wget' with the
--progress=dot:giga
option to avoid countless number of lines in the CI log since the input data is really big.Originally posted by @phil-blain in #587 (comment)
The text was updated successfully, but these errors were encountered: