-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verbosity control and mesh generation imprv. #15
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 85.40% 87.15% +1.75%
==========================================
Files 9 9
Lines 877 942 +65
==========================================
+ Hits 749 821 +72
+ Misses 128 121 -7
Continue to review full report at Codecov.
|
okay @WPringle this is ready to be merged. any input? |
I would like to keep the generator as simple as possible and instead make the mesh size function and domain classes take on the complexity for example to support multiscale mesh generation in a more general way. As you can see the mesh generator just takes a domain and an edge_length function. The both can be simple functions that take points and returns a size and signed distance etc. |
I like that change to inputting max allowable spacing of shoreline and edgefx in meters rather than degrees. At present we do just the divide by 111e3 to convert to degrees for the shoreline. I suppose that be fine. Another way we could use the haversine formula inside the interpm routine to make it more precise. |
The other comment I have is on the make traversable. Let's change |
Similarly |
I think putting Haversine function is a good idea and agree about the name changes in the API. |
Alright, I changed I also added a test for the README code. Eventually, we should move over to tox to handle testing on different versions of Python and to separate out testing deps with the main installation deps as the average user won't be testing. I think the Haversine thing should come in later versions. |
SeismicMesh
developments namely faster unique edge calculations. No parallel yet (not necessary).