Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUnseal: permit any in-bound type #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CUnseal: permit any in-bound type #87

wants to merge 1 commit into from

Conversation

nwf
Copy link
Member

@nwf nwf commented Nov 15, 2024

FIXES #71

rmn30
rmn30 requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@rmn30 rmn30 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add something to the change log and perhaps expand the comment to be more specific about when cs2 is "unable to authorize the sealing"? Have you checked for other mentions of unsealing in the arch doc that might need tweaking?

@rmn30
Copy link
Collaborator

rmn30 commented Nov 18, 2024

Looks like the text already says that CUnseal works with for any inbounds otype so it is currently a bit inconsistent. Please update the changelog and doc comment, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmn30 rmn30 rmn30 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow CUnseal to work on ranges
2 participants
@nwf @rmn30