WIP: SpeeDee Delivery Integration #97
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
cgsmith
reviewed
Dec 28, 2022
console/migrations/m221227_200815_create_speedee_manifests_table.php
Outdated
Show resolved
Hide resolved
samdark
reviewed
Dec 28, 2022
added 3 commits
December 28, 2022 13:35
cdwieber
commented
Dec 29, 2022
cdwieber
commented
Dec 29, 2022
| 'utf8' => false, | ||
| 'passive' => true, | ||
| 'transferMode' => FTP_BINARY, | ||
| 'systemType' => null, // 'windows' or 'unix' |
There was a problem hiding this comment.
double check these params
cgsmith
reviewed
Dec 30, 2022
|
|
||
| $adapter = new FtpAdapter( | ||
| FtpConnectionOptions::fromArray([ | ||
| 'host' => Yii::$app->params['speedeeFtpHost'], |
There was a problem hiding this comment.
I think this is fine. But we may need to store customers user and pass in meta data and pull from there.
added 10 commits
December 30, 2022 13:13
samdark
reviewed
Feb 9, 2023
| { | ||
| return [ | ||
| [['order_id', 'customer_id', 'ship_from_zip', 'weight', 'length', 'width', 'height', 'oversized', 'pickup_tag', 'aod', 'aod_option', 'cod', 'cod_value', 'declared_value', 'package_handling', 'apply_package_handling', 'unboxed'], 'integer'], | ||
| [['ship_date'], 'safe'], |
There was a problem hiding this comment.
Should we ensure a data format?
|
|
||
| namespace common\models\shipping\extension; | ||
|
|
||
| use Cassandra\Date; |
|
|
||
| $filename = $this->customer_number | ||
| . '.' | ||
| . Carbon::now()->format('Ymd') |
There was a problem hiding this comment.
Suggested change
| . Carbon::now()->format('Ymd') | |
| . (new \DateTime())->format('Ymd') |
Requiring whole carbon package just for that is an overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.