Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control Port Stats on decoder side issue #366

Open
TheSashmo opened this issue Dec 14, 2023 · 4 comments
Open

Control Port Stats on decoder side issue #366

TheSashmo opened this issue Dec 14, 2023 · 4 comments

Comments

@TheSashmo
Copy link

Seems like the control ports stats when enabled only report back two channels instead of 16 when the encoded signal has 16 coming into the decoder. Using release version, I have not tried continuous.
@mpiatka
Copy link
Collaborator

mpiatka commented Dec 18, 2023 •
edited
Loading

I've changed that a while ago in the continuous version which can now report more audio channels. Right now it's limited to 8 though. Would raising the limit to 16 be enough your use case?

@TheSashmo
Copy link
Author

Yes that would be correct. Ideally should match what the encoder supports.

mpiatka added a commit that referenced this issue Jan 22, 2024
@mpiatka
control_socket: Make reported audio ch count configurable
8c1b1d3 
And raise the default to 16. Refers to GH-366
@mpiatka
Copy link
Collaborator

mpiatka commented Jan 22, 2024

Alright, I made the default 16 and also made it configurable through --param control-report-audio-ch-count=<count>.

@TheSashmo
Copy link
Author

OK thanks I will test it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpiatka @TheSashmo