flow_age_stats: Added categorization based on FLOW_END_REASON #234

vaclavbartos · 2024-07-25T15:38:10Z

Module can now output statistics and graphs for each value of FLOW_END_REASON separately.

Co-authored-by: Václav Bartoš <[email protected]>

cejkato2 · 2024-08-28T13:40:14Z

flow_age_stats/flow_age_stats.c

+   bin* bins;
+   stat* first;
+   stat* last;


Suggested change

bin* bins;

stat* first;

stat* last;

bin *bins;

stat *first;

stat *last;

cejkato2 · 2024-08-28T13:40:27Z

flow_age_stats/flow_age_stats.c

+   stat* last;
+   uint8_t reason;
+   int count;
+   struct category_t* next;


Suggested change

struct category_t* next;

struct category_t *next;

cejkato2 · 2024-08-28T13:41:01Z

flow_age_stats/flow_age_stats.c

+//declaration of functions
+bin* createNode(uint64_t max, uint64_t count);
+void categorizeIntoCats(category* curr, uint64_t first_diff, uint64_t last_diff, uint8_t end_reason);
+category* createCategory(category* next, uint8_t reason);


Suggested change

category* createCategory(category* next, uint8_t reason);

category *createCategory(category* next, uint8_t reason);

cejkato2 · 2024-08-28T13:42:15Z

flow_age_stats/flow_age_stats.c

+void destroyCategory(category* current);
+void printCategories(category* head, int flow_count);
+void outputInFiles(category* head, int flow_count);


Suggested change

void destroyCategory(category* current);

void printCategories(category* head, int flow_count);

void outputInFiles(category* head, int flow_count);

void destroyCategory(category *current);

void printCategories(category *head, int flow_count);

void outputInFiles(category *head, int flow_count);

cejkato2 · 2024-08-28T13:42:39Z

flow_age_stats/flow_age_stats.c

@@ -173,20 +193,29 @@ int main(int argc, char **argv)
      fprintf(stderr, "Error: Input template could not be created.\n");
      return -1;
   }
+   if(endReas == 5){


Suggested change

if(endReas == 5){

if (endReas == 5){

cejkato2 · 2024-08-28T13:43:01Z

flow_age_stats/flow_age_stats.c

-        current = current->next;
-    }
-   current->next = createNode(0, 0);
+   category* head = createCategory(NULL, 0);


Suggested change

category* head = createCategory(NULL, 0);

category *head = createCategory(NULL, 0);

cejkato2 · 2024-08-28T13:43:10Z

flow_age_stats/flow_age_stats.c

+   if(head == NULL){
+      destroyCategory(head);
+   }
+   category* curr = head;


Suggested change

category* curr = head;

category *curr = head;

cejkato2 · 2024-08-28T13:43:29Z

flow_age_stats/flow_age_stats.c

+      }
+      else{


Suggested change

}

else{

} else {

cejkato2 · 2024-08-28T13:43:44Z

flow_age_stats/flow_age_stats.c

+
+
+   //should be outputed to file if specified
+   if (file == 1){


Suggested change

if (file == 1){

if (file == 1) {

cejkato2 · 2024-08-28T13:43:55Z

flow_age_stats/flow_age_stats.c

+
+   // clean categories
+   while (head != NULL){
+      category* next = head->next;


Suggested change

category* next = head->next;

category *next = head->next;

cejkato2 · 2024-08-28T13:44:10Z

flow_age_stats/flow_age_stats.c

+ * @param count counts inside the Node are initialized to this value
+*/
+bin* createNode(uint64_t max, uint64_t count){
+   bin* new_node = (bin*)malloc(sizeof(bin));


Suggested change

bin* new_node = (bin*)malloc(sizeof(bin));

bin *new_node = (bin *) malloc(sizeof(bin));

cejkato2 · 2024-08-28T13:44:45Z

flow_age_stats/flow_age_stats.c

+category* createCategory(category* next, uint8_t reason){
+   category* newCat = (category*)malloc(sizeof(category));


Suggested change

category* createCategory(category* next, uint8_t reason){

category* newCat = (category*)malloc(sizeof(category));

category *createCategory(category *next, uint8_t reason)

{

category *newCat = (category *) malloc(sizeof(category));

cejkato2 · 2024-08-28T13:45:16Z

flow_age_stats/flow_age_stats.c

+   current->next = createNode(0, 0);
+
+   //creating stat structs
+   newCat->first = (stat*)malloc(sizeof(stat));


Suggested change

newCat->first = (stat*)malloc(sizeof(stat));

newCat->first = (stat *) malloc(sizeof(stat));

cejkato2 · 2024-08-28T13:45:28Z

flow_age_stats/flow_age_stats.c

+   newCat->first->min = UINT64_MAX;
+   newCat->first->max = 0;
+
+   newCat->last = (stat*)malloc(sizeof(stat));


Suggested change

newCat->last = (stat*)malloc(sizeof(stat));

newCat->last = (stat *) malloc(sizeof(stat));

cejkato2 · 2024-08-28T13:45:45Z

flow_age_stats/flow_age_stats.c

+ * 
+ * @param current category to be destroyed
+ */
+void destroyCategory(category* current){


Suggested change

void destroyCategory(category* current){

void destroyCategory(category *current)

{

cejkato2 · 2024-08-28T13:45:58Z

flow_age_stats/flow_age_stats.c

+ * @param current category to be destroyed
+ */
+void destroyCategory(category* current){
+   if(current == NULL){


Suggested change

if(current == NULL){

if (current == NULL) {

cejkato2 · 2024-08-28T13:47:18Z

There are too many coding style issues, please improve the code according to https://nemea.liberouter.org/developer/coding-style-c
I suggested some of the changes.

flow_age_stats: Added categorization based on FLOW_END_REASON

108c84c

Co-authored-by: Václav Bartoš <[email protected]>

vaclavbartos requested a review from SiskaPavel July 25, 2024 15:43

cejkato2 reviewed Aug 28, 2024

View reviewed changes

flow_age_stats/flow_age_stats.c Outdated

Comment on lines 287 to 288

}

else{

Copy link

Contributor

cejkato2 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

}

else{

} else {

cejkato2 reviewed Aug 28, 2024

View reviewed changes

flow_age_stats: Fixed coding style

c8624f5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

flow_age_stats: Added categorization based on FLOW_END_REASON #234

flow_age_stats: Added categorization based on FLOW_END_REASON #234

vaclavbartos commented Jul 25, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024 •

edited

Loading

cejkato2 Aug 28, 2024 •

edited

Loading

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 Aug 28, 2024

cejkato2 commented Aug 28, 2024

	category* createCategory(category* next, uint8_t reason);
	category createCategory(category next, uint8_t reason);

	category* head = createCategory(NULL, 0);
	category *head = createCategory(NULL, 0);

	bin* new_node = (bin*)malloc(sizeof(bin));
	bin new_node = (bin ) malloc(sizeof(bin));

		category* createCategory(category* next, uint8_t reason){
		category* newCat = (category*)malloc(sizeof(category));

	newCat->first = (stat*)malloc(sizeof(stat));
	newCat->first = (stat *) malloc(sizeof(stat));

	newCat->last = (stat*)malloc(sizeof(stat));
	newCat->last = (stat *) malloc(sizeof(stat));

	void destroyCategory(category* current){
	void destroyCategory(category *current)
	{

flow_age_stats: Added categorization based on FLOW_END_REASON #234

Are you sure you want to change the base?

flow_age_stats: Added categorization based on FLOW_END_REASON #234

Conversation

vaclavbartos commented Jul 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cejkato2 Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

cejkato2 Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cejkato2 commented Aug 28, 2024

cejkato2 Aug 28, 2024 •

edited

Loading

cejkato2 Aug 28, 2024 •

edited

Loading