Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ISE 500 when non-numerical value appears in range search in JSON column #953

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Jul 8, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

When we try to use non-numerical value in range search, query fails with Internal server error because of incorrectly formatted jsonpath.

What is the new behaviour?

When value doesn't look like a number or known JSON literal, value is properly quoted and escaped before put in the jsonpath query.

Test plan

Added automated test to fulfill use-case mentioned in related issue

Closing issues

closes #952

@psrok1 psrok1 merged commit f37645f into master Jul 9, 2024
12 checks passed
@psrok1 psrok1 deleted the fix/non-numerical-range-search branch July 9, 2024 09:31
@psrok1 psrok1 mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute searching: search strings lexicographically
1 participant