Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set level of repetable logs to debug #909

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Set level of repetable logs to debug #909

merged 4 commits into from
Feb 12, 2024

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Feb 12, 2024

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

We're buried in tons of non-meaningful logs without any option to set the verbosity. Non-meaningful logs are:

  • information about usage of deprecated endpoints
  • 'before_request'/'request' logs which are useful for debugging hanging or slow endpoints, but only for debugging
  • threadName, moduleName, lineNo which doesn't carry any useful information that can't be read from the log itself

Missing request logs can be easily replaced with metrics introduced by #908

What is the new behaviour?

  • introducing DEBUG level that can be turned on via enable_debug_log option in configuration
  • setting verbosity level of logs mentioned above to DEBUG

@psrok1 psrok1 merged commit 0661052 into master Feb 12, 2024
12 checks passed
@psrok1 psrok1 deleted the fix/logging-verbosity branch February 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant