-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't query ObjectPermission table when user has access_all_objects capability #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch cannot pass tests due to a problem with karton-mwdb-reporter |
psrok1
force-pushed
the
refactor/access-all-object-capability
branch
from
June 22, 2023 12:23
9bc480c
to
7556542
Compare
psrok1
force-pushed
the
refactor/access-all-object-capability
branch
from
June 22, 2023 14:05
7556542
to
b85c243
Compare
psrok1
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I've added migration and bumped Karton services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
When new sample is added, we add new entry in
ObjectPermission
table for every user withaccess_all_objects
capabilityThis causes that we have many unnecessary rows in this table and MWDB works slower
Additionally, it's harder to revoke access to objects, when user loses the
access_all_objects
capabilityWhat is the new behaviour?
Instead of adding new rows in
ObjectPermission
, check if user hasaccess_all_objects
capability when queryingWhen user loses
access_all_objects
capability, they lose access to them (applies only in cases, when access to object is granted only by this capability)Test plan
Under development
Closing issues
closes #758