add new field in config, check upload size #756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
Users can upload as big file as they want and administrator doesn't have any tools (inside MWDB) to prevent that.
What is the new behaviour?
Administrator can configure limit for uploaded files
Checking file's size is not precise. In order to simplify the code, I check
Content-Length
field in request header. This value is bigger that actual file size by +/- 500B.In my opinion this error margin is acceptable - in most scenarios the limit will be set to megabytes, so even if the other values in request were 1 kB, the margin of error would be less that 0.1%
Test plan
Change values of
max_upload_size
in config and try to upload a file.Closing issues
closes #9