Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'count' field for object listing endpoints #755

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

Repumba
Copy link
Contributor

@Repumba Repumba commented Mar 10, 2023

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

Listing endpoints always limit number of returned objects to 10

What is the new behaviour?

When requesting list of objects, user can specify a new count field and set the limit manually.
If the field is not provided, value is set to 10 by default.

Maximal number of returned objects is limited in MWDB's configuration (default value is 1 000).

Test plan

  1. Manually test API
  2. I've added automatic tests

Closing issues

closes #754

@Repumba Repumba marked this pull request as ready for review March 10, 2023 13:53
@psrok1 psrok1 merged commit 3b42e3c into master Mar 14, 2023
@psrok1 psrok1 deleted the feature/config-list-count branch March 14, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for 'count' field for object listing endpoints
2 participants