Develop OAuth logout #732
Merged
Develop OAuth logout #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrok1
force-pushed
the
fix/oauth-endpoints
branch
from
4102844
to
2a39c73
Compare
psrok1
requested changes
Jan 23, 2023
mwdb/model/migrations/versions/bd93d1497694_create_logout_endpoint_column.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Paweł Srokosz <[email protected]>
psrok1
reviewed
Feb 15, 2023
psrok1
requested changes
Feb 15, 2023
Co-authored-by: Paweł Srokosz <[email protected]>
Co-authored-by: Paweł Srokosz <[email protected]>
Co-authored-by: Paweł Srokosz <[email protected]>
Co-authored-by: Paweł Srokosz <[email protected]>
Co-authored-by: Paweł Srokosz <[email protected]>
psrok1
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
MWDB doesn't store logout endpoint
It is impossible to logout from OAuth provider (from mwdb level)
What is the new behaviour?
MWDB stores logout endpoint
It is possible to logout from OAuth provider (from mwdb level)
Test plan
Start docker-compose-oidc-dev.yml
-> try adding new OIDC provider and use discover endpoint
-> login using OAuth and then click logout
Closing issues
closes #731