Fix: unable to delete objects with comments #702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
What is the current behaviour?
We're unable to delete object with comments.
What is the new behaviour?
Problem was caused by two relationships between Object and Comment table that were trying to reconcilate the fact that Object is deleted:
cascade="delete"
included that deletes all comments that are orphanedThese actions are in conflict that can be solved using
passive_deletes=True
, because foreign key constraints have already setondelete
behavior.In addition, I set
passive_deletes
on comments as well to make sqlalchemy not even bother about that relationship (ondelete
does the job passively from the SQLAlchemy perspective)I don't know why it never happened before, maybe bug was somehow exposed by flattening the object inheritance model in 2.8.0.
Test plan
Closing issues
closes #697