-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the documentation, and add a developer docker-compose #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msm-code
force-pushed
the
feature/documentation
branch
from
April 5, 2020 22:24
c2f93a1
to
6e036bd
Compare
nazywam
reviewed
Apr 5, 2020
msm-code
force-pushed
the
feature/documentation
branch
2 times, most recently
from
April 5, 2020 23:05
544dc06
to
29e6f46
Compare
msm-code
force-pushed
the
feature/documentation
branch
from
April 5, 2020 23:06
29e6f46
to
0a8d8a4
Compare
ITAYC0HEN
reviewed
Apr 6, 2020
ITAYC0HEN
requested changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! :)
Co-Authored-By: Itay Cohen <[email protected]>
Co-Authored-By: Itay Cohen <[email protected]>
ITAYC0HEN
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major rewrite of the documentation.
The original goal was to add a short instruction for new contributors, but it kinda went out of control.
I've also noticed many problems with the workflow while describing it, so I've changed the recommended developer environment to docker-compose.yml.
Fixes #31.