Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and publish docker images #262

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Build and publish docker images #262

merged 1 commit into from
Jan 12, 2022

Conversation

nazywam
Copy link
Member

@nazywam nazywam commented Jan 11, 2022

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running mquery, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
No docker images are built or pushed

What is the new behaviour?
web.Dockerfile and daemon.Dockerfile are built on pull requests and the images are pushed to mqueryci/mquery-web and mqueryci/mquery-daemon respectively.

No code changes

Test plan

See if the images are build and pushed properly

Closing issues

@nazywam nazywam requested a review from msm-code January 11, 2022 12:36
Copy link
Contributor

@msm-code msm-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks familiar. Should work (we might consider pushing release tags in the future though).

@nazywam nazywam merged commit 04f296e into master Jan 12, 2022
@nazywam nazywam deleted the feature/build-docker branch January 12, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants