Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the query window wider #241

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Make the query window wider #241

merged 2 commits into from
Dec 4, 2021

Conversation

msm-code
Copy link
Contributor

@msm-code msm-code commented Dec 1, 2021

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running mquery, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
The query window is a bit narrow, and cuts of larger yara rules.

What is the new behaviour?
Some changes here:

  1. During the initial edition, editor takes a whole width of the window - it's basically free real estate:
    ss

  2. Later this is reduced to a half window's width - still more than 5/12 and is enough for a bit wider rules:
    ss

Test plan
Take a look at the screens. (or run mquery and ensure that the app really looks like this and there are no weird issues).

Closing issues

fixes #195

@msm-code
Copy link
Contributor Author

msm-code commented Dec 2, 2021

Peek 2021-12-02 01-19

@msm-code msm-code merged commit 91eeeb9 into master Dec 4, 2021
@msm-code msm-code deleted the fix/wider-query-window branch December 24, 2021 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we apply word-wrapping in Monaco?
2 participants