Show query time after the query is done #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it's not possible to check how long the query took, and it's a pretty interesting information (at least for me, the developer).
ITAYC0HEN
reviewed
May 16, 2020
Co-authored-by: Itay Cohen <[email protected]>
ITAYC0HEN
approved these changes
May 18, 2020
KWMORALE
pushed a commit
to KWMORALE/mquery
that referenced
this pull request
Jul 29, 2020
Co-authored-by: Itay Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's not possible to check how long the query took,
and it's a pretty interesting information (at least for me, the developer).
Your checklist for this pull request
What is the current behaviour?
Information when the query was finished is not saved and shown anywhere
What is the new behaviour?
That small "took 19s" in the lower right corner under the progress bar
Test plan
Run a query, ensure that
took XXXstext is shown after the query is done (also when it's cancelled or it errors out).