Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small formatting for the results table #167

Merged
merged 2 commits into from
May 14, 2020

Conversation

ITAYC0HEN
Copy link
Collaborator

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running mquery, and testing changed functionality (if applicable)

What is the current behaviour?
Currently, the results table contains two columns, one for hashes and the other for sha256.
When clicking on the hash in a cell, the hash will be copied to the clipboard
image

What is the new behaviour?
Since we enjoy tons of space on this table, and because we plan to add more info (file size, mwdb data, ...) I thought of making a few cosmetic changes.

Changes made:

  • One column to contain everything nicely
  • I believe that the sha256 is more important for the user than the internal filename, so I made it the main item in the
  • A copy icon for both file name and hashes, visible on cell hover
  • A download icon, visible on cell hover

image

Peek 2020-05-13 20-43

Test plan

  • Check that hashes are copied correctly
  • Check that filenames are copied correctly
  • Check that download works correctly
  • Check files with loooooong file names (can use the browser's developers-tools for this)

src/mqueryfront/src/QueryResultsStatus.js Show resolved Hide resolved
src/mqueryfront/src/QueryResultsStatus.js Show resolved Hide resolved
src/mqueryfront/src/QueryResultsStatus.js Outdated Show resolved Hide resolved
@ITAYC0HEN ITAYC0HEN marked this pull request as ready for review May 14, 2020 07:21
Copy link
Contributor

@msm-code msm-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@msm-code msm-code merged commit 6f7f32e into CERT-Polska:master May 14, 2020
KWMORALE pushed a commit to KWMORALE/mquery that referenced this pull request Jul 29, 2020
* Results table formatting

* Adress feedback from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants