Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse storage UI for config #132

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Reuse storage UI for config #132

merged 1 commit into from
Apr 29, 2020

Conversation

msm-code
Copy link
Contributor

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running mquery, and testing changed functionality (if applicable)
  • [n/a] I've added automated tests for my change (if applicable, optional)
  • [n/a... yet] I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
No way to configure plugins (there are also no plugins but hey, we're working on it)

What is the new behaviour?
plugin configuration UI!

Test plan

  1. Go to mquery/storage page
  2. Type some random things
  3. Nothing is saved yet, because there is no backend.
  4. But UI should work.

ss

@msm-code msm-code requested a review from psrok1 April 29, 2020 19:46
@msm-code msm-code merged commit 4275a9d into master Apr 29, 2020
@msm-code msm-code deleted the feature/storage-ui branch April 29, 2020 20:07
KWMORALE pushed a commit to KWMORALE/mquery that referenced this pull request Jul 29, 2020
@msm-code @KWMORALE
Reuse storage UI for config (CERT-Polska#132)
4052584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psrok1 psrok1 psrok1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msm-code @psrok1